Repository navigation
Conversation
A well-formed ts-ec cookie whose row did not exist still went to bidders as user.id and as the ts-{ec} request ID on the navigation auction, /_ts/page-bids and /auction, although orphan recovery replaces that EC on the navigation. With an EC store, the EC now goes to bidders only when the request snapshot holds a consented row for it, the rule identity providers already follow. /_ts/page-bids and /auction read the row whenever an EC store exists, and a navigation without Fetch Metadata that runs an auction reads it too. Without an EC store no row exists and no EC is replaced, so the consented EC is still sent. The change is bidder-visible and recorded in the changelog.
Closes #1549.
Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
State that adapters without an EC KV store (Axum, Cloudflare, Spin) still send the consented EC as user.id, and record the consented-row rule in the S2S EID spec's compatibility notes. Signed-off-by: dhruv8sh <dhruv8sh@proton.me>
This was referenced Nov 20, 2026
3 tasks
dhruv8sh
marked this pull request as ready for review
November 20, 2026 09:12
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts-eccookie whose row does not exist was still sent to bidders asuser.idandrequest.id = ts-{ec}, and orphan recovery then rotated that EC on the same navigation. Bidders now get the EC only when the request read a consented row for it./_ts/page-bidsand/auction. This is bidder-visible, so it has a CHANGELOG entry.Changes
crates/trusted-server-core/src/auction/endpoints.rsbidder_ec_id: returns the EC only when the snapshot holds a consented row (or there is no EC store). Used by/auction;/auctionand page-bids now read the row whenever an EC store exists. Unit tests for unread, missing, unreadable, withdrawn and consented rows and for no store.crates/trusted-server-core/src/publisher.rsuser.idafter the row read; page-bids corrects its trace request throughset_auction_ec_identityonce the row is read. Handler tests for row and no-row cases.CHANGELOG.mddocs/superpowers/specs/2026-10-30-s2s-eid-collection-design.mdCloses
Closes #1549
Spec
Not a feature (bug fix; follow-up from #1487, design in
docs/superpowers/specs/2026-10-30-s2s-eid-collection-design.md).Test plan
cargo test-fastly && cargo test-axum(alsotest-cloudflare,test-spin)cargo clippy-fastly && cargo clippy-axum(alsoclippy-cloudflare,clippy-spin-native)cargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest run(no JS changes)cd crates/trusted-server-js/lib && npm run format(no JS changes)cargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveChecklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)